[SPARK-11994][Mllib] Word2VecModel load and save cause SparkException when model is bigger than spark.kryoserializer.buffer.max#9989
[SPARK-11994][Mllib] Word2VecModel load and save cause SparkException when model is bigger than spark.kryoserializer.buffer.max#9989tmnd1991 wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
1 << 25? Can you explain the rationale in a quick comment here, and what 41 comes from?
|
I explained it on the Jira issue, I'm going to explain it again here: |
|
@tmnd1991 Yes, I know. I'm suggesting you explain it not in the JIRA or PR, but briefly as comments in the code.
|
|
I adjusted the code as you suggested |
|
This is tagged to the wrong JIRA right? It's SPARK-11994 |
|
Yes, it was wrong, I fixed it, sorry. |
|
Test build #2126 has finished for PR 9989 at commit
|
|
I adjusted the code style. |
|
(The title is still wrong, it's SPARK-11994) |
|
Test build #2127 has finished for PR 9989 at commit
|
|
Something went wrong with the commit. |
|
@MechCoder @rxin any thoughts on this one? looks reasonable unless there's some reason it has to be in 1 partition. |
|
Test build #2134 has finished for PR 9989 at commit
|
|
Checking with @mengxr @jkbradley too just in case |
|
Merged to master |
No description provided.